Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this-property-fallback is not a possibility on ember >=4 #2185

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from
Open

this-property-fallback is not a possibility on ember >=4 #2185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions packages/compat/src/resolver-transform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,10 @@ function builtInKeywords(emberVersion: string): Record<string, BuiltIn | undefin
return builtInKeywords;
}

function supportsThisFallback(emberVersion: string): boolean {
return satisfies(emberVersion, '<= 4.0-alpha.0', { includePrerelease: true });
}

interface ComponentResolution {
type: 'component';
specifier: string;
Expand Down Expand Up @@ -184,6 +188,7 @@ class TemplateResolver implements ASTPlugin {
private env: Env,
private config: CompatResolverOptions,
private builtInsForEmberVersion: ReturnType<typeof builtInKeywords>,
private supportsThisFallback: boolean,
private externalNameHint?: ExternalNameHint
) {
this.moduleResolver = new Resolver(config);
Expand Down Expand Up @@ -549,17 +554,17 @@ class TemplateResolver implements ASTPlugin {

2. Have a mustache statement like: `{{something}}`, where `something` is:

a. Not a variable in scope (for example, there's no preceeding line
a. Not a variable in scope (for example, there's no preceeding line
like `<Parent as |something|>`)
b. Does not start with `@` because that must be an argument from outside this template.
c. Does not contain a dot, like `some.thing` (because that case is classically
c. Does not contain a dot, like `some.thing` (because that case is classically
never a global component resolution that we would need to handle)
d. Does not start with `this` (this rule is mostly redundant with the previous rule,
d. Does not start with `this` (this rule is mostly redundant with the previous rule,
but even a standalone `this` is never a component invocation).
e. Does not have any arguments. If there are argument like `{{something a=b}}`,
there is still ambiguity between helper vs component, but there is no longer
e. Does not have any arguments. If there are argument like `{{something a=b}}`,
there is still ambiguity between helper vs component, but there is no longer
the possibility that this was just rendering some data.
f. Does not take a block, like `{{#something}}{{/something}}` (because that is
f. Does not take a block, like `{{#something}}{{/something}}` (because that is
always a component, no ambiguity.)

We can't tell if this problematic case is really:
Expand All @@ -573,7 +578,7 @@ class TemplateResolver implements ASTPlugin {

2. A component invocation, which you could have written `<Something />`
instead. Angle-bracket invocation has been available and easy-to-adopt
for a very long time.
for a very long time.

3. Property-this-fallback for `{{this.something}}`. Property-this-fallback
is eliminated at Ember 4.0, so people have been heavily pushed to get
Expand Down Expand Up @@ -626,7 +631,7 @@ class TemplateResolver implements ASTPlugin {
}
}

if (!hasArgs && !path.includes('/') && !path.includes('@')) {
if (!hasArgs && !path.includes('/') && !path.includes('@') && this.supportsThisFallback) {
// this is the case that could also be property-this-fallback. We're going
// to force people to disambiguate, because letting a potential component
// or helper invocation lurk inside every bit of data you render is not
Expand Down Expand Up @@ -986,7 +991,13 @@ export default function makeResolverTransform({ appRoot, emberVersion, externalN
visitor: {},
};
}
return new TemplateResolver(env, config, builtInKeywords(emberVersion), externalNameHint);
return new TemplateResolver(
env,
config,
builtInKeywords(emberVersion),
supportsThisFallback(emberVersion),
externalNameHint
);
Comment on lines +994 to +1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the TemplateResolver constructor also take in 5 positional parameters?

};
(resolverTransform as any).parallelBabel = {
requireFile: __filename,
Expand Down
Loading