Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@embroider/macros and type=module #1906

Draft
wants to merge 13 commits into
base: stable
Choose a base branch
from
Draft

@embroider/macros and type=module #1906

wants to merge 13 commits into from
+99 −1

Commits on Nov 19, 2024

  1. make addon a module 

    Addon-main is cjs, it should have cjs extension

Reproduction success

Make separate scenario

Test file must end with -test

Need to update the app's ember-cli-babel

Test is passing, now let's break it again...

Break successful
    @NullVoxPopuli
    NullVoxPopuli committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    6813416 View commit details
    Browse the repository at this point in the history

  2. Reduce test to just es-compat resolving

    @NullVoxPopuli
    NullVoxPopuli committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    fb6fad0 View commit details
    Browse the repository at this point in the history

  3. Passes (incorrectly)

    @NullVoxPopuli
    NullVoxPopuli committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    79be440 View commit details
    Browse the repository at this point in the history

  4. fails (correctly)

    @NullVoxPopuli
    NullVoxPopuli committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    8b3ced6 View commit details
    Browse the repository at this point in the history

  5. Minimal test, pre fix

    @NullVoxPopuli
    NullVoxPopuli committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2cbea4b View commit details
    Browse the repository at this point in the history

  6. lint:fix

    @NullVoxPopuli
    NullVoxPopuli committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3770b65 View commit details
    Browse the repository at this point in the history

  7. Reduce diff from origin/stable

    @NullVoxPopuli
    NullVoxPopuli committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    61ebd7e View commit details
    Browse the repository at this point in the history

  8. The fix

    @NullVoxPopuli
    NullVoxPopuli committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    1596a37 View commit details
    Browse the repository at this point in the history

  9. addon-main MUST be cjs

    @NullVoxPopuli
    NullVoxPopuli committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0b1f3df View commit details
    Browse the repository at this point in the history

  10. use maybeEmbroider

    @NullVoxPopuli
    NullVoxPopuli committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    09d1ec5 View commit details
    Browse the repository at this point in the history

  11. Reduce diff

    @NullVoxPopuli
    NullVoxPopuli committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    15e89a0 View commit details
    Browse the repository at this point in the history

  12. Reduce diff

    @NullVoxPopuli
    NullVoxPopuli committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    619fe44 View commit details
    Browse the repository at this point in the history

  13. Backout lockfile changes

    @NullVoxPopuli
    NullVoxPopuli committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2f87396 View commit details
    Browse the repository at this point in the history