Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bugfixes: true to Babel's config #584

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

boris-petrov
Copy link
Contributor

That leads to (much) smaller code and will be the default in Babel 8. I got to that because my targets contains safari >= 16 but due to this code was transpiled for much older browsers. I fixed the problem for classic packages in Ember (by adding bugfixes: true to babel in ember-cli-build.js) but for ember-auto-imported ones I couldn't - this flag is needed for them.

@ef4 have I done the correct thing here?

@ef4
Copy link
Collaborator

ef4 commented Jun 29, 2023

Thanks, this seems like a good idea, and from reading the description of the bug fixes: true option is seems pretty safe to enable as a non-breaking change.

I think the test failures here are happening because some of the stuff being left un-transpiled now doesn't work in the node version we're testing under. It may be that we just need to add node to the targets for those test cases.

1 similar comment
@ef4
Copy link
Collaborator

ef4 commented Jun 29, 2023

Thanks, this seems like a good idea, and from reading the description of the bug fixes: true option is seems pretty safe to enable as a non-breaking change.

I think the test failures here are happening because some of the stuff being left un-transpiled now doesn't work in the node version we're testing under. It may be that we just need to add node to the targets for those test cases.

@boris-petrov
Copy link
Contributor Author

@ef4 thanks for the review! Do you want me to do it or are you? I'll need a pointer or two if it's going to be me - what should be changed and where. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants