Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove built-time error for root-path module not found #546

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

richgt
Copy link

@richgt richgt commented Oct 21, 2022

Simliar to #530, this should resolve embroider-build/embroider#1266, where dependencySatisfies is used, but because the module isn't found in build, it fails. Converts to a run-time failure.

@velrest
Copy link

velrest commented Nov 25, 2024

Hey @richgt
Do you know what holding up this issue? Our app kinda depends on embroider-build/embroider#1266 to be resolved.
Can I help in any way?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependencySatisfies doesn't work properly with optional peer dependencies
2 participants