[WIP] Fix bad transform of this parameter in TS #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagenet
changed the title
wagenet
force-pushed
the
fix-bad-transform-of-fake-this
branch
from
96d9a5c
to
de821cf
Compare
The biggest change in the diff here is that they switched to snapshot based testing for transform tests.
wagenet
force-pushed
the
fix-bad-transform-of-fake-this
branch
from
34930d6
to
21f0c46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #73. Fixes #71. However, a more comprehensive solution is still desirable as discussed here: #71 (comment).