Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native ember types #308

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use native ember types #308

wants to merge 2 commits into from

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Nov 9, 2024

Requires #306

Supersedes: #118

@NullVoxPopuli NullVoxPopuli added the enhancement New feature or request label Nov 9, 2024
@NullVoxPopuli NullVoxPopuli changed the base branch from main to ember-source-is-required-for-babel-plugin-ember-template-compilation November 9, 2024 19:31
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review November 9, 2024 20:43
"@types/ember__component": "^4.0.21",
"@types/ember__modifier": "^4.0.8",
"@types/ember__helper": "^4.0.5",
"@types/ember__routing": "^4.0.19",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

files/__addonLocation__/tsconfig.json Outdated Show resolved Hide resolved
Base automatically changed from ember-source-is-required-for-babel-plugin-ember-template-compilation to main November 10, 2024 21:02
@NullVoxPopuli NullVoxPopuli marked this pull request as draft November 10, 2024 21:09
"allowImportingTsExtensions": true,

"types": [
"ember-source/types"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches the TS App Blueprint rn

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review November 11, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants