-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native ember types #308
Open
NullVoxPopuli
wants to merge
2
commits into
main
Choose a base branch
from
native-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+6
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
native-types
branch
from
November 9, 2024 19:31
2af6741
to
c53335b
Compare
NullVoxPopuli
changed the base branch from
main
to
ember-source-is-required-for-babel-plugin-ember-template-compilation
November 9, 2024 19:31
simonihmig
reviewed
Nov 10, 2024
"@types/ember__component": "^4.0.21", | ||
"@types/ember__modifier": "^4.0.8", | ||
"@types/ember__helper": "^4.0.5", | ||
"@types/ember__routing": "^4.0.19", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Base automatically changed from
ember-source-is-required-for-babel-plugin-ember-template-compilation
to
main
November 10, 2024 21:02
NullVoxPopuli
force-pushed
the
native-types
branch
from
November 11, 2024 01:46
c53335b
to
f0f6a3e
Compare
NullVoxPopuli
commented
Nov 11, 2024
"allowImportingTsExtensions": true, | ||
|
||
"types": [ | ||
"ember-source/types" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matches the TS App Blueprint rn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #306
Supersedes: #118