Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addon dependencies #299

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Update addon dependencies #299

merged 1 commit into from
Nov 10, 2024

Conversation

simonihmig
Copy link
Collaborator

No description provided.

@simonihmig
Copy link
Collaborator Author

The failing test here should get fixed by

I think we should do the first at the minimum, but still can decide to also do the second if that seems better overall!? cc @patricklx

@simonihmig
Copy link
Collaborator Author

waiting for Enforce correct plugin order in addon-dev embroider#2136

Updating to [email protected] fixed that issue. Remaining failing tests here are unrelated, failing everywhere else as well! 😕

@simonihmig simonihmig marked this pull request as ready for review October 16, 2024 21:37
@NullVoxPopuli NullVoxPopuli added the enhancement New feature or request label Nov 10, 2024
@NullVoxPopuli NullVoxPopuli merged commit c476b77 into main Nov 10, 2024
16 of 17 checks passed
@NullVoxPopuli NullVoxPopuli deleted the update-deps branch November 10, 2024 21:37
@github-actions github-actions bot mentioned this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants