Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prettier separately #183

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Aug 17, 2023

Please review per commit.
We have not been running prettier on this repo, so the changes are bigger than normal.

We also get additional errors with prettier in the addon, (seen in #138)

Context:

Benefits:

  • eslint is faster
  • aligns with prettier recommendations
  • allows for managing script order and/or task caching if someone were to use a tool like turbo or nx

@@ -9,8 +9,12 @@
"license": "MIT",
"author": "simonihmig <[email protected]>",
"scripts": {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have not previously been running prettier on this repo, so we have more changes than normal

@Windvis
Copy link

Windvis commented Oct 14, 2023

Could we also change the config so it only uses single quotes for js/ts code and doubles for everything else?

We did a similar change in the v1 and app blueprint a while ago: https://github.com/ember-cli/ember-cli/pull/10062/files

I was planning to PR it but it seems that will most likely conflict with this one 😄. This is what I did to support gjs in a v1 addon, but for v2 we probably need to add .cjs and .mjs as well?:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants