lint releaseDate properly #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagenet
approved these changes
Sep 6, 2022
kategengler
reviewed
Sep 6, 2022
| @@ -155,6 +155,7 @@ describe('FrontmatterLinter', function () { | |||
| 'prs.accepted must be the URL for the original pull request on emberjs/rfcs, for example: https://github.com/emberjs/rfcs/pull/123', | |||
| 'start-date must be a date formatted YYYY-MM-DD', | |||
| 'teams must be a list of one or more Ember teams', | |||
| 'release-date must be a date formatted YYYY-MM-DD', | |||
There was a problem hiding this comment.
Is this correct though? On an early stage, do we want submitters of RFCs to see the message 'release-date must be a date formatted YYYY-MM-DD'? Because that is what this test is saying.
There was a problem hiding this comment.
Also noticing, pretty sure the messages are incorrect if we're now requiring iso dates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the releaseDate needs to be parsable we shouldn't allow any releaseDate that isn't a date. The release date should be either null or a parsable date 👍