Skip to content

allow setting moduleName from caller context #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

allow setting moduleName from caller context #98

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38c08d0
allow setting moduleName from caller context
void-mAlex Jun 24, 2025
38086a2
lint fix
void-mAlex Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import type { EmberTemplateCompiler, PreprocessOptions } from './ember-template-
import { LegacyModuleName } from './public-types.js';
import { ScopeLocals } from './scope-locals.js';
import { type ASTPluginBuilder, preprocess, print } from '@glimmer/syntax';
import { basename, extname } from 'node:path';

export * from './public-types.js';

Expand Down Expand Up @@ -143,6 +144,7 @@ interface State<EnvSpecificOptions> {
program: NodePath<t.Program>;
lastInsertedPath: NodePath<t.Statement> | undefined;
filename: string;
moduleName?: string;
recursionGuard: Set<unknown>;
}

Expand Down Expand Up @@ -408,7 +410,7 @@ function buildPrecompileOptions<EnvSpecificOptions>(
// TODO: embroider's template-compiler allows this to be overriden to get
// backward-compatible module names that don't match the real name of the
// on-disk file. What's our plan for migrating people away from that?
moduleName: state.filename,
moduleName: state.moduleName || basename(state.filename, extname(state.filename)),

// This is here so it's *always* the real filename. Historically, there is
// also `moduleName` but that did not match the real on-disk filename, it
Expand Down