-
-
Notifications
You must be signed in to change notification settings - Fork 55
chore: migrate to vite #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MehulKChaudhari
wants to merge
11
commits into
ember-learn:main
Choose a base branch
from
MehulKChaudhari:mirgrate-to-vite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9a00a1b
chore: migrate to vite
MehulKChaudhari 0b4a7ff
fix: proxy issue and css configuration
MehulKChaudhari 63971b6
fix: lint
MehulKChaudhari 67b4de3
fix: ember-percy and emebr-mirage package
MehulKChaudhari 252b820
fix: ember-mirage github direct dependency to version
MehulKChaudhari d87f489
chore: update percy ember
MehulKChaudhari cc792c2
update import path
MehulKChaudhari d0f04f5
fix percy issue
MehulKChaudhari b9f194e
Revert "fix percy issue"
MehulKChaudhari 95c59c2
fix - css pipeline to support vite
MehulKChaudhari cbc8671
fix - additional roots
MehulKChaudhari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| /tmp/ | ||
|
|
||
| # compiled output | ||
| /dist/ | ||
| /declarations/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,19 @@ | ||
| import Application from '@ember/application'; | ||
| import Resolver from 'ember-resolver'; | ||
| import loadInitializers from 'ember-load-initializers'; | ||
| import config from 'ember-help-wanted/config/environment'; | ||
| import config from './config/environment'; | ||
| import { importSync, isDevelopingApp, macroCondition } from '@embroider/macros'; | ||
|
|
||
| import compatModules from '@embroider/virtual/compat-modules'; | ||
|
|
||
| if (macroCondition(isDevelopingApp())) { | ||
| importSync('./deprecation-workflow'); | ||
| } | ||
|
|
||
| export default class App extends Application { | ||
| modulePrefix = config.modulePrefix; | ||
| podModulePrefix = config.podModulePrefix; | ||
| Resolver = Resolver; | ||
| Resolver = Resolver.withModules(compatModules); | ||
| } | ||
|
|
||
| loadInitializers(App, config.modulePrefix); | ||
| loadInitializers(App, config.modulePrefix, compatModules); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import loadConfigFromMeta from '@embroider/config-meta-loader'; | ||
|
|
||
| export default loadConfigFromMeta('ember-help-wanted'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| const { | ||
| babelCompatSupport, | ||
| templateCompatSupport, | ||
| } = require('@embroider/compat/babel'); | ||
| const scopedCSS = require('ember-scoped-css/build'); | ||
|
|
||
| module.exports = { | ||
| plugins: [ | ||
| [ | ||
| 'babel-plugin-ember-template-compilation', | ||
| { | ||
| compilerPath: 'ember-source/dist/ember-template-compiler.js', | ||
| enableLegacyModules: [ | ||
| 'ember-cli-htmlbars', | ||
| 'ember-cli-htmlbars-inline-precompile', | ||
| 'htmlbars-inline-precompile', | ||
| ], | ||
| transforms: [...templateCompatSupport(), scopedCSS.templatePlugin({})], | ||
| }, | ||
| ], | ||
| [ | ||
| 'module:decorator-transforms', | ||
| { | ||
| runtime: { | ||
| import: require.resolve('decorator-transforms/runtime-esm'), | ||
| }, | ||
| }, | ||
| ], | ||
| [ | ||
| '@babel/plugin-transform-runtime', | ||
| { | ||
| absoluteRuntime: __dirname, | ||
| useESModules: true, | ||
| regenerator: false, | ||
| }, | ||
| ], | ||
| ...babelCompatSupport(), | ||
| ], | ||
|
|
||
| generatorOpts: { | ||
| compact: false, | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ | |
| "test": "tests" | ||
| }, | ||
| "scripts": { | ||
| "build": "ember build --environment=production", | ||
| "build": "vite build", | ||
| "format": "prettier . --cache --write", | ||
| "lint": "concurrently \"npm:lint:*(!fix)\" --names \"lint:\" --prefixColors auto", | ||
| "lint:dependency": "ember dependency-lint", | ||
|
|
@@ -23,92 +23,99 @@ | |
| "lint:hbs:fix": "ember-template-lint . --fix", | ||
| "lint:js": "eslint . --cache", | ||
| "lint:js:fix": "eslint . --fix", | ||
| "start": "ember serve", | ||
| "start": "vite", | ||
| "start:local": "cross-env LOCAL_API=true ember s", | ||
| "test": "concurrently \"npm:lint\" \"npm:test:*\" --names \"lint,test:\" --prefixColors auto", | ||
| "test:ember": "ember test" | ||
| "test:ember": "vite build --mode test && ember test --path dist" | ||
| }, | ||
| "devDependencies": { | ||
| "@babel/core": "^7.26.10", | ||
| "@babel/eslint-parser": "^7.26.10", | ||
| "@babel/plugin-proposal-decorators": "^7.25.9", | ||
| "@babel/core": "^7.27.4", | ||
| "@babel/eslint-parser": "^7.27.5", | ||
| "@babel/plugin-proposal-decorators": "^7.27.1", | ||
| "@babel/plugin-transform-runtime": "^7.27.4", | ||
| "@ember/optional-features": "^2.2.0", | ||
| "@ember/string": "^3.0.1", | ||
| "@ember/test-helpers": "^5.1.0", | ||
| "@ember/string": "^4.0.1", | ||
| "@ember/test-helpers": "^5.2.2", | ||
| "@ember/test-waiters": "^4.1.0", | ||
| "@embroider/macros": "^1.16.12", | ||
| "@eslint/js": "^9.23.0", | ||
| "@glimmer/component": "^1.0.0", | ||
| "@embroider/compat": "^4.1.0", | ||
| "@embroider/config-meta-loader": "^1.0.0", | ||
| "@embroider/core": "^4.1.1", | ||
| "@embroider/macros": "^1.18.0", | ||
| "@embroider/vite": "^1.1.5", | ||
| "@eslint/js": "^9.29.0", | ||
| "@glimmer/component": "^1.1.2", | ||
| "@glimmer/tracking": "^1.1.2", | ||
| "@percy/cli": "^1.30.7", | ||
| "@percy/ember": "^3.0.1", | ||
| "@percy/cli": "^1.31.0", | ||
| "@percy/ember": "github:NullVoxPopuli/percy-ember#nvp/make-vite-compatible-via-the-compat-plugin", | ||
| "@percy/sdk-utils": "^1.31.0", | ||
| "@rollup/plugin-babel": "^6.0.4", | ||
| "@sinonjs/fake-timers": "^7.1.2", | ||
| "broccoli-asset-rev": "^3.0.0", | ||
| "concurrently": "^9.1.2", | ||
| "babel-plugin-ember-template-compilation": "^2.4.1", | ||
| "concurrently": "^9.2.0", | ||
| "cross-env": "^7.0.3", | ||
| "dayjs": "^1.11.13", | ||
| "decorator-transforms": "^2.3.0", | ||
| "ember-auto-import": "^2.10.0", | ||
| "ember-cli": "~6.3.1", | ||
| "ember-cli-app-version": "^7.0.0", | ||
| "ember-cli-babel": "^8.2.0", | ||
| "ember-cli-clean-css": "^3.0.0", | ||
| "ember-cli-dependency-checker": "^3.3.3", | ||
| "ember-cli-dependency-lint": "^2.0.1", | ||
| "ember-cli-deprecation-workflow": "^3.3.0", | ||
| "ember-cli-htmlbars": "^6.3.0", | ||
| "ember-cli-inject-live-reload": "^2.1.0", | ||
| "ember-cli-netlify": "^0.4.1", | ||
| "ember-cli-sri": "^2.1.1", | ||
| "ember-cli-terser": "^4.0.2", | ||
| "ember-data": "~5.3.11", | ||
| "ember-functions-as-helper-polyfill": "^2.1.2", | ||
| "ember-data": "~5.3.13", | ||
| "ember-functions-as-helper-polyfill": "^2.1.3", | ||
| "ember-load-initializers": "^3.0.1", | ||
| "ember-math-helpers": "^3.0.0", | ||
| "ember-mirage": "^0.4.2", | ||
| "ember-modifier": "^4.2.0", | ||
| "ember-mirage": "github:mansona/ember-mirage#fix-qunit-timing&path:ember-mirage", | ||
| "ember-modifier": "^4.2.2", | ||
| "ember-page-title": "^8.2.4", | ||
| "ember-qunit": "^8.1.1", | ||
| "ember-resolver": "^12.0.1", | ||
| "ember-scoped-css": "^0.23.2", | ||
| "ember-scoped-css-compat": "^10.2.1", | ||
| "ember-qunit": "^9.0.3", | ||
| "ember-resolver": "^13.1.1", | ||
| "ember-scoped-css": "^0.23.3", | ||
| "ember-source": "~6.0.1", | ||
| "ember-styleguide": "^7.1.0", | ||
| "ember-template-imports": "^4.3.0", | ||
| "ember-template-lint": "^6.1.0", | ||
| "ember-test-selectors": "^6.0.0", | ||
| "eslint": "^9.23.0", | ||
| "eslint": "^9.29.0", | ||
| "eslint-config-prettier": "^9.1.0", | ||
| "eslint-plugin-ember": "^12.5.0", | ||
| "eslint-plugin-n": "^17.16.2", | ||
| "eslint-plugin-n": "^17.20.0", | ||
| "eslint-plugin-qunit": "^8.1.2", | ||
| "glob": "^7.2.3", | ||
| "globals": "^15.15.0", | ||
| "http-proxy": "^1.18.1", | ||
| "invert-color": "^2.0.0", | ||
| "lint-to-the-future": "^2.6.2", | ||
| "lint-to-the-future-ember-template": "^3.0.0", | ||
| "lint-to-the-future-eslint": "^3.0.0", | ||
| "lint-to-the-future": "^2.6.3", | ||
| "lint-to-the-future-ember-template": "^3.1.0", | ||
| "lint-to-the-future-eslint": "^3.1.0", | ||
| "lint-to-the-future-stylelint": "^1.1.0", | ||
| "loader.js": "^4.7.0", | ||
| "luxon": "^2.5.2", | ||
| "miragejs": "^0.1.48", | ||
| "morgan": "^1.10.0", | ||
| "normalize.css": "^8.0.1", | ||
| "prettier": "^3.5.3", | ||
| "prettier-plugin-ember-template-tag": "^2.0.4", | ||
| "prettier": "^3.6.1", | ||
| "prettier-plugin-ember-template-tag": "^2.0.6", | ||
| "qunit": "^2.24.1", | ||
| "qunit-dom": "^3.4.0", | ||
| "stylelint": "^16.16.0", | ||
| "stylelint": "^16.21.0", | ||
| "stylelint-config-standard": "^36.0.1", | ||
| "tracked-built-ins": "^3.4.0", | ||
| "util": "^0.12.5", | ||
| "webpack": "^5.98.0" | ||
| "vite": "^6.3.5" | ||
| }, | ||
| "engines": { | ||
| "node": ">= 18" | ||
| }, | ||
| "ember": { | ||
| "edition": "octane" | ||
| }, | ||
| "packageManager": "[email protected]+sha512.df0136e797db0cfa7ec1084e77f3bdf81bacbae9066832fbf95cba4c2140ad05e64f316cde51ce3f99ea00a91ffc702d6aedd3c0f450f895e3e7c052fe573cd8" | ||
| "packageManager": "[email protected]+sha512.df0136e797db0cfa7ec1084e77f3bdf81bacbae9066832fbf95cba4c2140ad05e64f316cde51ce3f99ea00a91ffc702d6aedd3c0f450f895e3e7c052fe573cd8", | ||
| "ember-addon": { | ||
| "type": "app", | ||
| "version": 2 | ||
| }, | ||
| "exports": { | ||
| "./tests/*": "./tests/*", | ||
| "./*": "./app/*" | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.