-
-
Notifications
You must be signed in to change notification settings - Fork 78
Revise Node.js support and Vagrant provider details #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Cleaned up language; updated link to latest Node support platforms. Updated recommendations for Node.js on Cygwin and Windows Subsystem Linux. Improved clarity on Vagrant provider performance.
✅ Deploy Preview for ember-cli-guides ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| Rather then using Cygwin, we recommend running Ember CLI natively on windows, | ||
| or via the new [Windows Subsystem | ||
| Linux](https://msdn.microsoft.com/en-us/commandline/wsl/install_guide). | ||
| Node.js on Cygwin or the [Windows Subsystem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wouldn't we support wsl? It's just linux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node doesn't support WSL without some extra work:
The Windows Subsystem for Linux (WSL) is not supported, but the GNU/Linux build process and binaries should work. .... Running the Windows binary (node.exe) in WSL will not work without workarounds such as stdio redirection. ↩
| Linux](https://msdn.microsoft.com/en-us/commandline/wsl/install_guide). | ||
| Node.js on Cygwin or the [Windows Subsystem | ||
| Linux](https://msdn.microsoft.com/en-us/commandline/wsl/install_guide) are [not supported](https://github.com/nodejs/node/blob/main/BUILDING.md#platform-list). | ||
| We recommend running Ember CLI natively on Windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot recommend this, but we do support it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running natively was in the original text:
Rather then using Cygwin, we recommend running Ember CLI natively on windows,
I edited the wording to align it to Node's supported platforms (WSL is problematic, as per the prior comment).
If that wasn't the intent, I'm happy to revert that change, just let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is WSL problematic, since it's just linux, and linux is fully supported?
Cleaned up language; updated link to latest Node support platforms. Updated recommendations for Node.js on Cygwin and Windows Subsystem Linux. Improved clarity on Vagrant provider performance.