breaking: conversion to v2 addon format

[aklkv]

If merged, this PR converts this addon to the V2 addon format. Resolves #359, #372, and #380.

Details

• moved dummy app into test-app
• converted the navigation-narrator component to gts
• moved the addon to the addon/src folder
• removed outdated/no longer used automation config files
• updated ember-try scenarios

Breaking Changes

• CSS has to be imported manually
• Dropped support for Ember versions earlier than v4.12
• Dropped support for Node versions earlier than v18

[aklkv]

@MelSumner I think this is ready to go, and hopefully CI passes, I have tested everything locally

[MelSumner]

@MelSumner I think this is ready to go, and hopefully CI passes, I have tested everything locally

I'll do my best to review this ASAP, can you make sure to update the PR description with the changes made?

[josephdsumner]

This should close a number if open issues. Once this is merged we can look into adding relase-plan.

Breaking changes:

• if consumer need css, it has to be now imported manually

@aklkv

Question: Do we need to do something similar in order for the stylelint floating-deps check to work properly?

[MelSumner]

Three things:

1. Please review the test that is failing
2. Check the updated description, I gave it a go but there may be more we wish to include.
3. Please add instructions to the README for how users need to import the CSS for the addon; I think that would be appropriate for this PR, since that changed in this PR.

Anything else that was a nice-to-have has been moved to separate issues.

Thank you so much! Can't wait to get this out as a new release!

[josephdsumner]

Approving this PR with the expectation that the sole outstanding floating-dependencies issue will be resolved before merge + release. It looks great -- both my and and @MelSumner 's change requests have either been made or appropriately scoped elsewhere to my satisfaction.

👍

[josephdsumner]

👍 thanks for looking into this -- I have approved the CI run.

[josephdsumner]

No luck -- I'll take a closer look at this against the latest v2 addon blueprint for stylelint deps / versions / config.

[aklkv]

I have a idea that it might be relate to pnpm v10 and --no-lockfile and verify-deps-before-run options, it might have been removed

[aklkv]

yep, here we go pnpm/pnpm#8865
it seems solution is in main but not release, I would say we can either skip this part of CI so we can merge this PR and them unskip when pnpm releases a new version which should not take too long, or just wait till release and then merge this PR. Optionally disable verify-deps-before-run flag for now

[josephdsumner]

Happy to see the fix has been identified and merged upstream. I'd hope for a quick turnaround for a release with our blocker fixed in there. Pnpm shipping a larger, slower release with a wave of fixes for the new major would be understandable.

Question: what do you think about filing this issue as a blocker for cutting our next release, but not letting it block this PR?

[aklkv]

Yeah it's not blocking at all, just nice to have. I have commented out this flag for now, since CI is green I think we are gtg, I will add some readme update in a bit + create follow up PR for uncommenting pnpm flag

[josephdsumner]

Question: is there any reason we can't keep pnpm@9 and ship both the PR and release immediately?

[aklkv]

you can ship immediately on pnpm@v10, without follow up PR as it's not really important for end consumer

[MelSumner]

Ok, I think this is good for now, we'll follow up with a few more PRs before cutting a release. Thank you for your contributions!!