feat(session): check sessionId and sessionStartTime before firing ses…

…sion:start event SUITEDEV-35464 Co-authored-by: Andras Sarro <[email protected]> Co-authored-by: matusekma <[email protected]> Co-authored-by: megamegax <[email protected]>
emartech · Apr 5, 2024 · 0a44cf1 · 0a44cf1
1 parent 0472bbe
commit 0a44cf1
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/HostApp/HostAppTests/EmarsysSDKTests/Session/MobileEngageSessionTests.swift b/HostApp/HostAppTests/EmarsysSDKTests/Session/MobileEngageSessionTests.swift
@@ -97,6 +97,16 @@ final class MobileEngageSessionTests: EmarsysTestCase {
  _ = try fakeEventClient.verify(\.fnSendEvents).times(times: .eq(0))
  }
 
+ func testStart_shouldNotSendEvent_when_sessionWasAlreadyStarted() async throws {
+ self.sessionContext.contactToken = "testContactToken"
+ self.sessionContext.sessionId = testUuid
+ self.session.sessionStartTime = testDate
+
+ await self.session.start()
+
+ _ = try fakeEventClient.verify(\.fnSendEvents).times(times: .eq(0))
+ }
+
  func testStart_shouldSet_sessionId_onSessionContext() async {
  await self.session.start()
 

diff --git a/Sources/EmarsysSDK/Session/MobileEngageSession.swift b/Sources/EmarsysSDK/Session/MobileEngageSession.swift
@@ -41,7 +41,7 @@ class MobileEngageSession: SessionApi {
  }
 
  func start() async {
- if ((self.sdkContext.config?.applicationCode != nil) && (self.sessionContext.contactToken != nil)) {
+ if (self.canStartSession()) {
  self.sessionStartTime = self.timestampProvider.provide()
  self.sessionContext.sessionId = self.uuidProvider.provide()
  do {
@@ -84,4 +84,11 @@ class MobileEngageSession: SessionApi {
  await self.stop()
  }
  }
+
+ private func canStartSession() -> Bool {
+ self.sdkContext.config?.applicationCode != nil &&
+ self.sessionContext.contactToken != nil &&
+ self.sessionContext.sessionId == nil &&
+ self.sessionStartTime == nil
+ }
 }