Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-doc): Hide doc frame on next post command #775

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

jcs090218
Copy link
Member

No description provided.

@jcs090218 jcs090218 merged commit b6d12dd into emacs-lsp:master Apr 23, 2024
11 of 12 checks passed
@brownts
Copy link
Contributor

brownts commented Apr 27, 2024

Hi @jcs090218, I'm seeing some odd behavior that seems to be related to this commit. In the past, I've been able to move the mouse pointer over the child frame and use the mouse wheel to scroll the child frame. Now, it appears as soon as I move the mouse pointer, the child frame disappears, so I can't scroll the child frame at all anymore. This worked either with lsp-ui-doc-show-with-cursor or with lsp-ui-doc-show-with-mouse. Can this capability be restored?

Another oddity appears to be the alternation of the child frame being displayed or hidden. I believe this happens both with mouse and cursor hover settings (i.e., lsp-ui-doc-show-with-mouse and lsp-ui-doc-show-with-cursor respectively), but is most prominent with the cursor hover setting. In that configuration, it's easy to see the problem. If point is over a word that causes the child frame to be displayed, each time I move the point (for example starting at the left of the word and moving right one character at a time), the child frame will alternate between being displayed and not being displayed. In the past, the child frame would stay displayed the entire time (possibly repositioning if lsp-ui-doc-position was set to at-point) as the point was moved to the right.

@jcs090218
Copy link
Member Author

I'll take a look!

@brownts
Copy link
Contributor

brownts commented May 8, 2024

Looks like someone else is having a similar problem related to this change:

@hellified
Copy link

hellified commented May 14, 2024

Yep, that's my cry for help on Reddit. I'll watch here for further developments. Super annoying to lose the ability to click the link in the box and pop open the browser with full docs.

I can volunteer to be a guinea pig for changes if that will help.

If there is an existing issue I can follow please let me know. I won't open one right away as you've already stated you're looking into it.

@jcs090218 jcs090218 deleted the fix/uf branch May 14, 2024 11:31
@jcs090218
Copy link
Member Author

Sorry, I was a little busy. I'll take a look tomorrow!

@jcs090218
Copy link
Member Author

I've reverted the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants