Prevent parent window margins from being used in UI doc child frame. #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When margins are used in the main window (such as Flymake/Flycheck diagnostic indicators in the margin instead of the fringe), causing `left-margin-width` and/or `right-margin-width` in the parent to be non-zero, the child frame was seeing those margins and text was being wrapped incorrectly. The child frame is sized to handle the amount of text on a line (up to `lsp-ui-doc-max-width`) and then `fill-region` is used to hard-wrap the text. The computation of the size of the frame assumes there are no fringes or margins which consume part of this frame. However, when the margin was visible in the child frame, it was causing text to be soft-wrapped prior to the hard-wrap. This change sets the margin sizes to 0 in the buffer of the child frame and then forces the window of the child frame to utilize these settings, preventing parent margins from being displayed in the child frame.
jcs090218
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When margins are used in the main window (such as Flymake/Flycheck diagnostic indicators in the margin instead of the fringe), causing
left-margin-widthand/orright-margin-widthin the parent to be non-zero, the child frame was seeing those margins and text was being wrapped incorrectly.The child frame is sized to handle the amount of text on a line (up to
lsp-ui-doc-max-width) and thenfill-regionis used to hard-wrap the text. The computation of the size of the frame assumes there are no fringes or margins which consume part of this frame. However, when the margin was visible in the child frame, it was causing text to be soft-wrapped prior to the hard-wrap.This change sets the margin sizes to 0 in the buffer of the child frame and then forces the window of the child frame to utilize these settings, preventing parent margins from being displayed in the child frame.