Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make adjustment to use vector function rather than vector literal #83

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

thatnerdjosh
Copy link
Contributor

Based on comment in #82

@thatnerdjosh
Copy link
Contributor Author

@factyy @yyoncho - made changes as per Wilfred's comment in the issue regarding the ht usage.

@factyy factyy merged commit 60e1103 into emacs-lsp:master Nov 21, 2023
11 of 12 checks passed
@factyy
Copy link
Collaborator

factyy commented Nov 21, 2023

@yyoncho @thatnerdjosh , thanks! Merged now

@sfavazza
Copy link
Contributor

sfavazza commented Dec 9, 2023

There is still a problem with the vector definition in the mapping, the hash-table is not evaluated. To test, try running this in a project:
(lsp-docker-get-path-mappings lsp-docker-persistent-default-config (lsp-workspace-root))

You should get the error: Wrong type argument: hash-table-p, (ht ('source ".") ('destination "/projects"))

I guess this is due to how vectors are defined in elisp, from the manual:

A vector, like a string or a number, is considered a constant for evaluation: the result of evaluating it is the same vector. This does not evaluate or even examine the elements of the vector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants