Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get list of buffers (not files) with breakpoints #768

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

sfavazza
Copy link
Contributor

This is a fix for a bug I erroneously introduces in PR #754 .

The function dap--buffers-w-breakpoints was returning a list of files names instead of a list of buffers. This in turn broke the dap--switch-to-session.

With this fix, the list of buffers is inferred by the first marker of the first breakpoint found for each file.

@sfavazza
Copy link
Contributor Author

@yyoncho is it critical that only the CI / test (windows-latest, snapshot, true) check does not pass?

@jcs090218
Copy link
Member

is it critical that only the CI / test (windows-latest, snapshot, true) check does not pass?

There is a bug with that emacs snapshot. We can ignore that for now.

Copy link
Member

@jcs090218 jcs090218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jcs090218 jcs090218 merged commit ed360fd into emacs-lsp:master Apr 3, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants