-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MS `vscode-js-debug' Installation and Integration #736
base: master
Are you sure you want to change the base?
Conversation
Add latest vscode-js-debug adaptor, update installation routines so vscode adaptors on Github can be easily installed. In order to make this work, updates for the latest DAP Spec for reverse requests.
There are some bits that should go in, and there are some pieces better to have from the other implementation. Let me think about it. |
Sounds great. Definitely try it out, and let me know if have any questions about what I've done, or want me to make changes, or anything else. Thank you for taking the time to look at it! |
Hi @yyoncho - Just checking if need anything from me on this PR. Let me know if you do. |
+ Remove child debug session from dap--debug-configuration, if added. This will allow `dap-debug-last' command to work using parent. + Other general long line reformatting to make more readable.
…l/dap-mode-PR into vscode-js-debug-feature
Resync'd with master. Then made a update for Probably should determine a more upstream option for not adding the child confs automatically when starting debug, if the reverse request child debug sessions becomes more common. For example, should there be logic in
What I did for now was look if Please, as always, let me know if have questions or feedback! Thanks so much! |
Shamelessly stolen from emacs-lsp#736
Shamelessly stolen from emacs-lsp#736
Shamelessly stolen from emacs-lsp#736
Shamelessly stolen from emacs-lsp#736
Shamelessly stolen from emacs-lsp#736
Shamelessly stolen from emacs-lsp#736
Shamelessly stolen from emacs-lsp#736
Add latest vscode-js-debug adaptor, update installation routines so vscode adaptors on Github can be easily installed. In order to make this work, updates for the latest DAP Spec for reverse requests. A few other minor updates.
Please let me know if any questions at all.