dap-python: Support attach mode #384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New configuration attribute `processId` is added. This name is picked to provide a consistent interface for both debugpy and ptvsd as well as make it works with launch.json naturally.
nbfalcon
approved these changes
Oct 12, 2020
dap-python.el
Outdated
| @@ -205,14 +206,17 @@ overriden in individual `dap-python' launch configurations." | |||
| (when (sequencep python-args) | |||
| (setq python-args (mapconcat #'shell-quote-argument python-args " "))) | |||
| (plist-put conf :program-to-start | |||
| (format "%s%s -m ptvsd --wait --host %s --port %s%s %s %s" | |||
| (format "%s%s -m ptvsd --wait --host %s --port %s %s" | |||
| (or dap-python-terminal "") | |||
There was a problem hiding this comment.
Suggested change
| (or dap-python-terminal "") | |
| (or (and dap-python-terminal (concat " " dap-python-terminal) "")) |
f279801
commented
Oct 12, 2020
yyoncho
reviewed
Oct 12, 2020
| @@ -205,14 +206,17 @@ overriden in individual `dap-python' launch configurations." | |||
| (when (sequencep python-args) | |||
| (setq python-args (mapconcat #'shell-quote-argument python-args " "))) | |||
| (plist-put conf :program-to-start | |||
| (format "%s%s -m ptvsd --wait --host %s --port %s%s %s %s" | |||
| (format "%s%s -m ptvsd --wait --host %s --port %s %s" | |||
There was a problem hiding this comment.
@nbfalcon not part of this review, but do we support vterm here?
There was a problem hiding this comment.
@yyoncho we could use vterm here, but not with the facilities that I have already implemented for "runInTerminal", as they depend on a debug-session. However, adding vterm support to dap-debug shouldn't be that much effort (basically let-bind vterm-shell to :program-to-start and then call (vterm)). I could implement it if I have some more spare time.
There was a problem hiding this comment.
It should be max. 20 lines of Elisp, probably 4-10.
Co-authored-by: Nikita Bloshchanevich <[email protected]>
|
Any chance that this will be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
processIdis added.This name is picked to provide a consistent interface for both debugpy
and ptvsd as well as make it works with launch.json naturally.