Fix helm matching functions defeated (#2134)

when a function is used as collection. * helm-mode.el (helm-comp-read): Always pass empty string to helm-comp-read-get-candidates.
emacs-helm · Mar 8, 2019 · 8de179d · 8de179d
1 parent 3a16b0e
commit 8de179d
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/helm-mode.el b/helm-mode.el
@@ -565,12 +565,12 @@ that use `helm-comp-read' See `helm-M-x' for example."
            (get-candidates
             (lambda ()
               (let ((cands (helm-comp-read-get-candidates
-                            collection test sort alistp
-                            ;; This should not be needed as
-                            ;; `helm-pattern' is not yet computed when
-                            ;; calling this from :init when
-                            ;; candidates-in-buffer is in use.
-                            (if candidates-in-buffer "" helm-pattern))))
+                            ;; If `helm-pattern' is passed as INPUT
+                            ;; and :alistp is nil INPUT is passed to
+                            ;; `all-completions' which defeat helm
+                            ;; matching functions (multi match, fuzzy
+                            ;; etc...) issue #2134.
+                            collection test sort alistp "")))
                 (helm-cr-default default cands))))
            (history-get-candidates
             (lambda ()