Remove RTags and bump minimum version to Emacs-28 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkryger
requested review from
philippe-grenet and
steve-downey
as code owners
pkryger
force-pushed
the
remove-legacy
branch
from
0e25c29 to
2bc46a7
Compare
In the advent of Language Server Protocols (LSP) tools like `lsp-mode` and `eglot` seem to be superior to what RTags has provided. Straight out of the box (and in case of `eglot` that is a built-in it is literally straight out of the box) they provide support to not only C++ but any language that has an LSP server available. Removing RTags support from Exordium doesn't mean it cannot be used with Exordium. It simply means that we decided not to maintain extensions code any more, as providing any reasonable support requires too much time.
Variables are obsolete since Emacs-31
pkryger
force-pushed
the
remove-legacy
branch
from
2bc46a7 to
7568274
Compare
|
@philippe-grenet @steve-downey just a friendly reminder to take look at this PR. Let me know if you have any questions or feedback. |
|
Sorry I couldn't find time yet, but I will review it this week. It is mostly code deletion anyway. |
Co-authored-by: Philippe Grenet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #227
Remove all RTags modules and all references I managed to find.
Also bump minimum supported version to Emacs-28 and remove all kludges that came
up while scrubbing the code. I have started adding comments like
Since Emacs-29orUntil Emacs-28to make next scrubbing session that little biteasier.