CI configs: add nix flake #1815
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krader1961
reviewed
May 26, 2024
|
|
||
| [mod] | ||
| [mod."github.com/creack/pty"] | ||
| version = "v1.1.21" |
There was a problem hiding this comment.
How will this dependency data be kept in sync with the go.mod file? If someone submits a change that updates the version of any of these packages (which I have done more than once) do they also have to update this file or is file somehow automatically kept in sync with the go.mod file for the project?
There was a problem hiding this comment.
This has to be updated together with the command
nix develop --command gomod2nix.
If adding flake is OK, I'll try to add workflow that generates automatic PR when dependancy changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elvish is already packaged in nix, but adding flake file in the project can provide reproducible build, develop environment.
And helpful for someone who wants to package any version of elvish they want (nightly build or even fork..).