Skip to content

Commit

Permalink
Issue-42 Adding support for impersonating groups with flag --as-group (
Browse files Browse the repository at this point in the history
  • Loading branch information
pratikkumar-mohite authored Apr 11, 2024
1 parent 91eeff5 commit 346dc40
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions pkg/cmd/view-secret.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ type CommandOpts struct {
secretKey string
quiet bool
impersonateAs string
impersonateAsGroups string
}

// NewCmdViewSecret creates the cobra command to be executed
Expand Down Expand Up @@ -94,6 +95,7 @@ func NewCmdViewSecret() *cobra.Command {
cmd.Flags().StringVarP(&res.customContext, "context", "c", res.customContext, "override the current context")
cmd.Flags().StringVarP(&res.kubeConfig, "kubeconfig", "k", res.kubeConfig, "explicitly provide the kubeconfig to use")
cmd.Flags().StringVar(&res.impersonateAs, "as", res.impersonateAs, "Username to impersonate for the operation. User could be a regular user or a service account in a namespace.")
cmd.Flags().StringVar(&res.impersonateAsGroups, "as-group", res.impersonateAsGroups, "Groups to impersonate for the operation. Multipe groups can be specified by comma separated.")

return cmd
}
Expand All @@ -119,6 +121,7 @@ func (c *CommandOpts) Retrieve(cmd *cobra.Command) error {
ctxOverride, _ := cmd.Flags().GetString("context")
kubeConfigOverride, _ := cmd.Flags().GetString("kubeconfig")
impersonateOverride, _ := cmd.Flags().GetString("as")
impersonateGroupOverride, _ := cmd.Flags().GetString("as-group")

var res, cmdErr bytes.Buffer
commandArgs := []string{"get", "secret", c.secretName, "-o", "json"}
Expand All @@ -138,6 +141,10 @@ func (c *CommandOpts) Retrieve(cmd *cobra.Command) error {
commandArgs = append(commandArgs, "--as", impersonateOverride)
}

if impersonateGroupOverride != "" {
commandArgs = append(commandArgs, "--as-group", impersonateGroupOverride)
}

out := exec.Command("kubectl", commandArgs...)
out.Stdout = &res
out.Stderr = &cmdErr
Expand Down

0 comments on commit 346dc40

Please sign in to comment.