feat(bn): migrate battle notifier to DB #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabloCorso
force-pushed
the
bn-store-to-db
branch
from
729e3f4
to
0d340f2
Compare
PabloCorso
force-pushed
the
bn-store-to-db
branch
from
0d340f2
to
699d12a
Compare
PabloCorso
force-pushed
the
bn-store-to-db
branch
from
699d12a
to
0bd52d2
Compare
PabloCorso
force-pushed
the
bn-store-to-db
branch
from
0bd52d2
to
9620ba4
Compare
|
Added migration script to generate base SQL statements to migrate bn.store.json to the new DB structure |
sunehs
reviewed
Sep 23, 2023
| @@ -29,7 +29,8 @@ export default { | |||
| }, | |||
| prefix: '!', | |||
| bn: { | |||
| storePath: '../bn/bn.store.json', | |||
| serverApiUrl: 'https://test.elma.online/api/player/bn/', | |||
There was a problem hiding this comment.
maybe it should use discord.url and just have "api/player/bn/" for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Battle Notifier migration discussion here.
What changes are proposed in this pull request?
Migrate current battle notifier user settings store with file system at
bn.store.jsonfile, to use the database instead.bnStore.jsmanages user settings storage. Update to call to the server API instead to get and post user settings from the server.apisauce.bnModelUtils.jsis a new file to handle data between API and bot code, to parse incoming notification settings from server model to bot model and viceversa.api/bn/:DiscordId- get user settingsapi/bn/:DiscordId- set user notification rulesapi/bn- gets all "active" settings withBnEnabledand at least oneBnKuskiRuleapi/bn/:DiscordId/toggle/:BnEnabled- turn notifications on/offapi/bn/:DiscordId/linked- is there an elma online user connected withDiscordIdjesttovitestand updated for the new logic.!bnbot remains the same, commands are unchanged. Added one new message for the first interaction with the bot. If you have not connected elma online user with your discord id you will now see the following intructions: