This repository was archived by the owner on May 5, 2020. It is now read-only.
Inherit protocol and endpoint when not specified.#12
Open
edevil wants to merge 2 commits intoelm-lang:masterfrom
Open
Inherit protocol and endpoint when not specified.#12edevil wants to merge 2 commits intoelm-lang:masterfrom
edevil wants to merge 2 commits intoelm-lang:masterfrom
Conversation
Author
|
Based on code from the Phoenix channels JS client. |
|
+1 to this |
Contributor
|
I didn't have @process-bot set up when this issue was opened, but this is what he would have said: https://github.com/elm-lang/virtual-dom/issues/30#issuecomment-232155244 |
edevil
force-pushed
the
implicit_endpoint
branch
from
a23087d to
18ca136
Compare
Author
|
Can I have some feedback on this please? |
|
Damn, 4 years and still going, what a shame... |
|
This is the old organization, the correct one is github.com/elm and it doesn't have websocket package and probably won't, explained here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easy to have the same code running in dev/staging/production environments since you are now able to use relative paths instead of absolute paths for the websocket endpoint.
Addresses fbonetti/elm-phoenix-socket#6