Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add account pinned tab #1921

Closed
wants to merge 2 commits into from
Closed

feat: add account pinned tab #1921

wants to merge 2 commits into from

Conversation

lazzzis
Copy link
Contributor

@lazzzis lazzzis commented Mar 23, 2023

Try to resolve #305

Add a new tab to show pinned posts.

Screenshot 2023-03-22 at 11 00 18 PM

@stackblitz
Copy link

stackblitz bot commented Mar 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Mar 23, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit c375ccb
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/641ce1ac03d0240008325a6f
😎 Deploy Preview https://deploy-preview-1921--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 23, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit c375ccb
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/641ce1ac08b07e000895f992

@sxzz
Copy link
Member

sxzz commented Mar 30, 2023

Actually, I don't think it is a good design to add a new tab, because we already had pinned page.
image

Maybe we can add pinned statuses to the top of Posts tab like Mastodon official.

@lazzzis
Copy link
Contributor Author

lazzzis commented Mar 30, 2023

because we already had pinned page

oh. I see. I was not aware of this feature. It seems it only allows me to see my own pinned posts. I am still unable to see pinned posts from other accounts. Is it possible to open pinned page of another user?

Maybe we can add pinned statuses to the top of Posts tab like Mastodon official.

Got it.

@lazzzis lazzzis closed this Mar 30, 2023
@sxzz
Copy link
Member

sxzz commented Mar 30, 2023

Seems no, we cannot open pinned page of other users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing info boxes in profile and pinned posts
2 participants