Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: base-ragsearch-plugin #944

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

alextitonis
Copy link
Collaborator

@alextitonis alextitonis commented Dec 9, 2024

Relates to:

Risks

Low, it's an external plugin

Background

What does this PR do?

Adds support for neo4j, users can add documents etc and do rag graph using the provider

What kind of change is this?

Documentation changes needed?

Testing

You can add the provider and try adding some docs and then use the query

Where should a reviewer start?

Detailed testing steps

@alextitonis alextitonis self-assigned this Dec 9, 2024
@alextitonis alextitonis marked this pull request as draft December 9, 2024 19:04
@alextitonis alextitonis marked this pull request as ready for review December 20, 2024 09:38
@alextitonis alextitonis changed the title base-ragsearch-plugin [feat] base-ragsearch-plugin Dec 20, 2024
@samarth30 samarth30 changed the title [feat] base-ragsearch-plugin feat: base-ragsearch-plugin Dec 27, 2024
@samarth30
Copy link
Collaborator

@alextitonis I just reviewed this PR, and I have a suggestion:

This implementation seems more suited to being an Adapter, similar to existing ones like PostgreSQL, Supabase, or SQL Adapters. Could you refactor it into an Adapter with all the relevant functions required for seamless integration?

Additionally, to ensure usability and proper testing, could you include an example demonstrating how this Adapter can be used with an Agent Client for testing purposes? This will help verify the implementation and provide a practical use case.

@alextitonis
Copy link
Collaborator Author

@alextitonis I just reviewed this PR, and I have a suggestion:

This implementation seems more suited to being an Adapter, similar to existing ones like PostgreSQL, Supabase, or SQL Adapters. Could you refactor it into an Adapter with all the relevant functions required for seamless integration?

Additionally, to ensure usability and proper testing, could you include an example demonstrating how this Adapter can be used with an Agent Client for testing purposes? This will help verify the implementation and provide a practical use case.

It's not meant to be used as a normal database as it's using a graph for storing data, but as an extra layer, that's why i made it like that.
For use case, you can store some memories and draw connections and then use the query to get docs.
For example user X is base.
Chat with X on twitter is on graph, connected to base X
Chat with X on discord is another graph, connected to base
You can query both graphs.
Also will search node by node as well to using the embedding. (not sure if i explained correctly, if not let me know)

@samarth30
Copy link
Collaborator

Looks great to me! Could you integrate this plugin with the Agent Client, following the same approach used for other plugin integrations?
can you also make a PR on Develop branch

@alextitonis
Copy link
Collaborator Author

Looks great to me! Could you integrate this plugin with the Agent Client, following the same approach used for other plugin integrations? can you also make a PR on Develop branch

Tried to follow the other plugins, is there something wrong? can fix it.
Will do the other PR as well

@samarth30
Copy link
Collaborator

Hi @alextitonis,

Could you include the plugin initialization in agent/src/index.ts, similar to how the other plugins have been integrated? This will ensure consistency across the project.

Also, it might be a good idea to define some actions so your plugin can be utilized effectively. By attaching the plugin to specific actions, it can seamlessly integrate into the workflow. Let me know if you’d like any support with this!

@alextitonis alextitonis force-pushed the base-ragsearch-plugin branch from 3163ce2 to b8b9ae9 Compare December 31, 2024 12:37
@alextitonis alextitonis changed the base branch from main to develop December 31, 2024 12:37
@alextitonis
Copy link
Collaborator Author

Hi @alextitonis,

Could you include the plugin initialization in agent/src/index.ts, similar to how the other plugins have been integrated? This will ensure consistency across the project.

Also, it might be a good idea to define some actions so your plugin can be utilized effectively. By attaching the plugin to specific actions, it can seamlessly integrate into the workflow. Let me know if you’d like any support with this!

Rebased to developer and added initialization, would be perfect if you could help with the action example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants