Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : github image cicd #889

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Conversation

v1xingyue
Copy link
Contributor

when relase published make github docker image.

@monilpat
Copy link
Collaborator

monilpat commented Dec 7, 2024

Looks good to me do you mind adding a test thanks!

@v1xingyue
Copy link
Contributor Author

I'm not sure what does test mean. This only do build and publish image when released. I think it should be tested and prepared for publish

@monilpat
Copy link
Collaborator

monilpat commented Dec 8, 2024

I'm not sure what does test mean. This only do build and publish image when released. I think it should be tested and prepared for publish

I mean just adding a screenshot of successful run of the .yaml file.

@v1xingyue
Copy link
Contributor Author

Ok that's fine I'll add that later

@v1xingyue
Copy link
Contributor Author

v1xingyue commented Dec 8, 2024

This is one exmple running github cicd.
https://github.com/v1xingyue/eliza/actions/runs/12220378514/job/34088113118
I think this is enough for test.

But there is something wrong with pnpm run build in docker image.
So I just modify it with :

"build": "turbo run build"

@v1xingyue v1xingyue changed the title github image cid github image cicd Dec 10, 2024
@v1xingyue
Copy link
Contributor Author

Done. Seems package.json provide
pnpm build-docker
command .
I change it in Dockerfile .

@v1xingyue v1xingyue changed the title github image cicd Feat : github image cicd Dec 11, 2024
@odilitime odilitime merged commit a882883 into elizaOS:main Dec 11, 2024
1 of 4 checks passed
@v1xingyue v1xingyue deleted the v1xingyue-patch-1 branch December 11, 2024 16:51
@odilitime odilitime changed the title Feat : github image cicd feat : github image cicd Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants