Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace unruggable-core with unruggable-sdk #450

Merged
merged 10 commits into from
Dec 26, 2024
Merged

feat: replace unruggable-core with unruggable-sdk #450

merged 10 commits into from
Dec 26, 2024

Conversation

remiroyc
Copy link
Contributor

Description

This PR proposes to replace the current implementation using unruggable-core with the newly published unruggable-sdk package. The SDK provides a more developer-friendly experience with:

  • Improved TypeScript support
  • More concise and readable API
  • Maintained wrapper around the core package functionality

Changes

  • Replace unruggable-core dependency with unruggable-sdk
  • Update relevant implementations to use the new SDK interface
  • Update types where necessary

Benefits

  • Better developer experience through improved typing
  • More maintainable code through cleaner abstractions
  • Same core functionality with a more ergonomic interface

@ponderingdemocritus ponderingdemocritus marked this pull request as ready for review November 21, 2024 09:21
@ponderingdemocritus
Copy link
Contributor

looks good - fix conflicts then lets ship

lalalune
lalalune previously approved these changes Nov 26, 2024
View reviewed changes
@lalalune lalalune changed the base branch from main to develop December 13, 2024 07:41
@odilitime odilitime deleted the branch elizaOS:develop December 13, 2024 19:07
@odilitime odilitime closed this Dec 13, 2024
@odilitime odilitime reopened this Dec 13, 2024
@odilitime odilitime deleted the branch elizaOS:develop December 17, 2024 02:33
@odilitime odilitime closed this Dec 17, 2024
@odilitime odilitime reopened this Dec 17, 2024
@shakkernerd shakkernerd deleted the branch elizaOS:develop December 17, 2024 03:44
@odilitime odilitime reopened this Dec 17, 2024
@shakkernerd shakkernerd deleted the branch elizaOS:develop December 22, 2024 07:01
@odilitime odilitime reopened this Dec 22, 2024
odilitime
odilitime previously approved these changes Dec 26, 2024
View reviewed changes
@odilitime odilitime merged commit cc4af0f into elizaOS:develop Dec 26, 2024
5 checks passed
@odilitime odilitime mentioned this pull request Dec 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ponderingdemocritus ponderingdemocritus ponderingdemocritus left review comments

@enitrat enitrat enitrat left review comments

@odilitime odilitime odilitime approved these changes

@lalalune lalalune lalalune left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@remiroyc @ponderingdemocritus @odilitime @lalalune @enitrat @shakkernerd