fix(#1411): downgrade NodeJS from 23.3.0 to 22.12.0 #1630
+42
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lachiejames have you had any compatibility issues? I think that we did this because of runtime onnx issues, also Node.js latest now supports type stripping to we can run native typescript without bundler |
@lalalune I hit deployment issues with Vercel since they only support up to Node v22. Happy to close it if Node v23 is required for specific features. |
odilitime
requested changes
Jan 3, 2025
|
Don't make any changes yet, I'll test the onnx stuff on 22 and let you know |
lachiejames
force-pushed
the
1411-fix_downgrade_nodejs_from_23.3.0_to_22.12.0_lts
branch
from
8c8f93d to
e389bf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Issue #1411 - Minimum Node LTS
Risks
Low - This change aligns the project with the current LTS version of Node.js, reducing potential compatibility issues and improving stability.
Background
What does this PR do?
Downgrades the project's Node.js version requirement from v23 to v22 (current LTS version) to ensure better stability and wider compatibility. This includes updating relevant documentation and configuration files.
See https://github.com/nodejs/release?tab=readme-ov-file#release-schedule
What kind of change is this?
NodeJS version requirement
Why are we doing this? Any context or related work?
I tried deploying the eliza-client on Vercel, but they only support up to Node v22. So deployments will immediately fail with this error.
The deployment succeeds on this branch with the following configuration:
Documentation changes needed?
Yes, added.
Testing
Where should a reviewer start?
Detailed testing steps
Discord username
lachiejames3677