fix: bugfix. the port 80 is not listening use 3000 #1616
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monilpat
requested changes
Dec 31, 2024
monilpat
previously approved these changes
Jan 1, 2025
monilpat
changed the title
3000 is listening on the docker image
odilitime
approved these changes
Jan 3, 2025
|
thanks yall, what a review process! I hope to have more substantial
patches, you can check this one i am working on.
meta-introspector#1
…On Sat, Jan 4, 2025, 00:03 Shakker Nerd ***@***.***> wrote:
Merged #1616 <#1616> into develop.
—
Reply to this email directly, view it on GitHub
<#1616 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD5KQ2OP3EWTNMQSALKZWYD2I5TSNAVCNFSM6AAAAABUNYXS62VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVHAYTEMZQGQ3TGMI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3000 is listening on the docker image
Risks
Low - This change affects the Docker container configuration. It may require updates to documentation and environment configurations where the container is deployed.
Background
What does this PR do?
This pull request updates the Dockerfile and related Docker configuration to expose port 3000 instead of port 80. This change is necessary to align with our application's configuration and avoid conflicts with other services running on port 80.
What kind of change is this?
Bug fixes (non-breaking change which fixes an issue)
N/A (Issue linked provides context)
Documentation changes needed?
My changes require a change to the project documentation. I have updated the documentation accordingly.
Testing
Where should a reviewer start?
Start by reviewing the changes in the Dockerfile and docker-compose.yml files.
Detailed testing steps
N/A
N/A
N/A
docker build
Discord username m1337d