Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tweak transfer template of plugin-evm #1604

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

zkvm
Copy link
Contributor

@zkvm zkvm commented Dec 31, 2024

Relates to:

Risks

Low

Background

Prerequisite: EVM_PRIVATE_KEY and EVM_PROVIDER_URL both configured in .env file and @elizaos/plugin-evm enabled for the agent.

Chatting with agent send 0.01 eth to <address> will result in an error ["⛔ Error: The chain ethereum not configured yet. Add the chain or choose one from configured: mainnet"] - using openai gpt-4o-mini model

What does this PR do?

Remove the description in the prompt that tells model that chain name Must be one of ["ethereum", ...]. Let it follows the content of SUPPORTED_CHAINS (e.g. "mainnet" | "base" | "holesky") - which is consistent with the definitions in viem/chains, with chainName of ethereum mainnet is mainnet, rather than ethereum.

What kind of change is this?

Bug fixes

Documentation changes needed?

No

Testing

Where should a reviewer start?

Detailed testing steps

@zkvm
Copy link
Contributor Author

zkvm commented Dec 31, 2024

this one is easy for review @shakkernerd

Copy link
Member

@shakkernerd shakkernerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it!

@shakkernerd shakkernerd merged commit 66c66fd into elizaOS:develop Dec 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants