Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update volcengine model #1586

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Conversation

zhourunlai
Copy link
Contributor

@zhourunlai zhourunlai commented Dec 31, 2024

Relates to:

Risks

Background

What does this PR do?

update volcengine large model and add model settings, doc: https://www.volcengine.com/docs/82379/1330310

What kind of change is this?

Improvements

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zhourunlai! Welcome to the ai16z community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now a ai16z contributor!

@zhourunlai zhourunlai changed the base branch from main to develop December 31, 2024 03:13
@zhourunlai zhourunlai force-pushed the volcengine_model branch 2 times, most recently from 5a7b5c5 to 31256b1 Compare December 31, 2024 03:50
@twilwa
Copy link
Contributor

twilwa commented Dec 31, 2024

I beleive this will need the necessary URL and request changes in models.ts, types.ts, generation.ts, et cetera. Unless that's on another PR then these changes won't work as intended.

@zhourunlai
Copy link
Contributor Author

zhourunlai commented Dec 31, 2024

I beleive this will need the necessary URL and request changes in models.ts, types.ts, generation.ts, et cetera. Unless that's on another PR then these changes won't work as intended.

Volcengine is compatible with openai’s API, so this can work in generateText

Copy link
Member

@shakkernerd shakkernerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me given the docs link clarifying that volcengine is compatible with OpenAI. Link here: https://www.volcengine.com/docs/82379/1330626

@shakkernerd shakkernerd merged commit 59ae83a into elizaOS:develop Dec 31, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants