-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add an client-direct endpoint to get memories by agentid and roomid #1581
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @treppers! Welcome to the ai16z community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now a ai16z contributor!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for doing this it has been such a pain to have to call const memories = await runtime.messageManager.getMemories({ roomId, });
everytime we want to see this during our test runs glad there is a route now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to merge this in as all nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nits are fine
Relates to:
Risks
Low. This change adds a new API endpoint for fetching memories, which should not affect existing functionality.
Background
What does this PR do?
This PR adds a new API endpoint /agents/:agentId/:roomId/memories to fetch memories for a specific agent and room. This enhancement supports improved web-based chat capabilities with Eliza characters.
What kind of change is this?
Features (non-breaking change which adds functionality)
Why are we doing this? Any context or related work?
Mee.fun a hosted Eliza service, want to add a web-based chat UI. In order to do this history of the chat needs to be retrievable.
Documentation changes needed?
My changes require a change to the project documentation. The new API endpoint should be documented in the appropriate API documentation.
Testing
Where should a reviewer start?
Detailed testing steps
Discord username
treppers