feat: Add anthropic image description #1436
Open
+314
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monilpat
requested changes
Dec 24, 2024
| @@ -97,11 +98,13 @@ export class ImageDescriptionService | |||
|
|
|||
| if (model === models[ModelProviderName.LLAMALOCAL]) { | |||
| await this.initializeLocalModel(); | |||
| } else if (model === models[ModelProviderName.ANTHROPIC]) { | |||
| this.modelId = "claude-3-haiku-20240307"; | |||
There was a problem hiding this comment.
Can we make this a env var and add this hard coded value as a default?
Comment on lines
+252
to
+254
| imageData, | ||
| 400, | ||
| 400 |
There was a problem hiding this comment.
You should be able to configure the dimensions of this can we pass that in as a param
| // Detect MIME type | ||
| const fileTypeResult = await FileType.fileTypeFromBuffer(imageBuffer); | ||
| if (!fileTypeResult || !fileTypeResult.mime.startsWith("image/")) { | ||
| throw new Error("Invalid image format"); |
There was a problem hiding this comment.
please elizaLogger before errors thanks
| }, | ||
| }, | ||
| }; | ||
| } catch (error) { |
odilitime
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Risks
Background
What does this PR do?
What kind of change is this?
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps