-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add CoinGecko plugin #1382
base: develop
Are you sure you want to change the base?
Conversation
Seems unnecessary to change the character files (provider switched for whatever reason), also the entire package.json instead of just adding the plugin. I know that's just a formatting thing but makes it more tedious to review. |
Ahh nm I see you added those characters originally. Just seemed unrelated to the PR. |
had some problems on DEV branch with antropic so I did change model to openai, but reverted now on this PR, as this is unrelated. |
about formating, isnt the setting for prettier set to 4 in all places, so seems to me this should be right formating of .json file? |
Going to test this but there are merge conflicts that need to be fixed. Might need to rebase this onto current develop branch to fix. I'm seeing some stuff that doesn't exist in current develop i.e. agent/src/index.ts everything but the addition of the import and |
thanx for review, develop moves fast so I didn't update it for 2 days and lots has changed, I merged current develop into mine so now there shouldn't be any conflict. |
This looks really clean now. Unfortunately I encountered an error attempting to test price retrieval -
|
try with openai as modelProvider, IDK why when using anthropic it gets this error, doesnt seem like problem with this plugin as it just sets "ModelClass.SMALL" and then in tiktoken module
this part gets some model that is not in the list, but seems more like general codebase problem, as I dont set the actual model in plugin. Please trace it out yourself and let me know what you think? |
adding empty line(s) on the end of file
|
Added lock file. yeah, sorry for too many fixes, was mostly because of the model issue and that the whole plugin namespace changed, so tracking this and updating to dev branch that is constantly moving was hard to catch, but in the end it all resulted in better code and better of understanding of the whole system. |
Adding a new plugin, where with free API from coingecko we can get price of a currency and its marketcap.
There are 2 actions, so we can fetch by name/ticker but also with address of token.
Added, Readme, .env config and integration to default agent if key is set.
Image attached for example how it makes output.