Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: birdeye provider to support all possible evm symbols #1366

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

simpletrontdip
Copy link
Contributor

@simpletrontdip simpletrontdip commented Dec 22, 2024

Relates to:

Expanding Birdeye thread
(Recreated after closed by develop deletion)

Risks

Low, we can use it in any plugin

Background

What does this PR do?

What kind of change is this?

Features (non-breaking change which adds functionality)

Why are we doing this? Any context or related work?

Birdeye provide data API for many symbols, not limited to SOL, such as WETH, BONK

Documentation changes needed?

I have added the README accordingly, this doesn't change anything in solana plugin, but it can be used there

Testing

Where should a reviewer start?

Detailed testing steps

None, automated tests are fine.

Screenshots

Before

After

Screenshot 2024-12-23 at 13 03 42 Screenshot 2024-12-23 at 13 00 50

Discord username

simpletrontdip

@simpletrontdip
Copy link
Contributor Author

@odilitime Please help check again. I've added a sample action and screenshots for it in action :D

odilitime
odilitime previously approved these changes Dec 23, 2024
@odilitime odilitime added Needs Testing Plugin_new Mark PRs that are a new plugin labels Dec 23, 2024
@swizzmagik
Copy link

Hey guys, I just dropped a PR to add more comprehensive support for Birdeye API. Check it out and let me know what you think: #1417

My MR also enables EVM data but the format may be a bit different.

@simpletrontdip
Copy link
Contributor Author

@odilitime I've had 3 rounds of rebasing now 👯 Can we proceed with a merge?
My bot can be called and work, already. Or, can we align how to test it more?

I think the approach in #1417, which provide a bunch of providers/facts without any params is not quite right (how can we inject tons of fact into our agent, but they're API calls, which require params).

@simpletrontdip
Copy link
Contributor Author

@twilwa can you help run this in your local, this is a similar thing you tested (#1417), for more details please help check above comments.
My approval was dismissed because of rebasing.

odilitime
odilitime previously approved these changes Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Testing Plugin_new Mark PRs that are a new plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants