Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mint nft with collection address #1274

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

xwxtwd
Copy link
Contributor

@xwxtwd xwxtwd commented Dec 20, 2024

Relates to:

N/A

Risks

Low

Background

What does this PR do?

Add a new action to plugin-nft-generation that allows minting NFTs to a specified collection address.

What kind of change is this?

Features (non-breaking change which adds functionality)

Documentation changes needed?

My changes do not require a change to the project documentation.

Testing

Where should a reviewer start?

  • Check the new action implementation in plugin-nft-generation/src/actions/mintNFTAction.ts
  • Review the action registration in plugin-nft-generation/src/index.ts

Detailed testing steps

  1. Ask the bot: create collection
  2. Ask the bot: Help me mint an NFT

@xwxtwd xwxtwd changed the base branch from main to develop December 20, 2024 15:06
@xwxtwd xwxtwd changed the title Feat/mint nft with collection address feat(plugin-nft-generation):mint nft with collection address Dec 20, 2024
@xwxtwd xwxtwd changed the title feat(plugin-nft-generation):mint nft with collection address feat:mint nft with collection address Dec 20, 2024
@xwxtwd xwxtwd changed the title feat:mint nft with collection address feat: Mint nft with collection address Dec 20, 2024
@xwxtwd xwxtwd force-pushed the feat/mint-NFT-with-collection-address branch from cdbfb6e to 3f87cbe Compare December 20, 2024 15:11
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this a few comments otherwise looking good :)

@shakkernerd shakkernerd deleted the branch elizaOS:develop December 22, 2024 07:02
@odilitime odilitime reopened this Dec 22, 2024
@xwxtwd xwxtwd force-pushed the feat/mint-NFT-with-collection-address branch from d3cdc12 to 8eac641 Compare December 23, 2024 01:37
@xwxtwd xwxtwd requested a review from monilpat December 23, 2024 02:41
@xwxtwd
Copy link
Contributor Author

xwxtwd commented Dec 26, 2024

Thanks for working on this a few comments otherwise looking good :)

All comments have been resolved. Thanks! @monilpat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants