Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: discord client ci issues #1054

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix: discord client ci issues #1054

merged 2 commits into from
Dec 13, 2024

Conversation

cygaar
Copy link
Collaborator

@cygaar cygaar commented Dec 13, 2024

Relates to:

The latest CI build fails due to incorrect interface definitions and unused variables. I also auto-linted these files.

Risks

Background

What does this PR do?

What kind of change is this?

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

@cygaar cygaar changed the base branch from main to develop December 13, 2024 23:05
monilpat
monilpat approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for doing this I was wondering when someone was going to fix the unused variable linter issue was about to add a PR myself thanks for doing this :)

@monilpat monilpat merged commit 970410d into elizaOS:develop Dec 13, 2024
4 checks passed
@cygaar cygaar deleted the fix_discord_ci branch December 13, 2024 23:45
@odilitime odilitime mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monilpat monilpat monilpat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cygaar @monilpat