chore: improving client typing

[BalanaguYashwanth]

Relates to:

#656

Risks

Medium

• It could effect the twitter client agent authentication flow

Background

What does this PR do?

Configured the multiple character agents with multiple twitter accounts, to run in parallel

What kind of change is this?

Bug fixes

• Multiple twitter clients works with multiple agents running simultaneously

Documentation changes needed?

Yes, twitter client related docs need changes, already added it

Testing

Where should a reviewer start?

• When starting the agent with twitter client, it should post a tweet and start interacting with the tweet

Files to be reviewed:

• agent/src/index.ts
• review the all files under
  • packages/client-twitter/src
• packages/core/src/environment.ts
• packages/core/tests/environment.test.ts
• packages/core/src/types.ts

Detailed testing steps

• Configure the multiple characters with their respecitve twitter client config
• Start the agent
• Check if the agent posts a tweet and starts interacting with the tweet
• Check if the multiple agents are running in parallel

[dev-cz]

Yes, this is a good fix. Lets get this one merged. A gap on the Twitter client, when running multiple agents.

[odilitime]

Definitely some code improvements here but how does using config improve on just using a secret/settings in each runtime?

[BalanaguYashwanth]

@odilitime If i want to configure each twitter account to the each agent, then using a secret/settings may not resolve the issue.

I configured in a way that if you didn't mentioned any config, it will take from secret/settings in each runtime or else it will take from config where custom credentials will loaded that helps you which account to load which specific client.

[BalanaguYashwanth]

@odilitime got it, Is this you are expecting, I didn't looked it this way. Yeah i think this instruction i didn't checked in docs.

so i created new PR with config setup. I think you can discard my PR. If below code works

"name": "Eliza",
    "clients": ["twitter"],
    "plugins": [],
    "modelProvider": "openai",
    "settings": {
        "secrets": {
            "TWITTER_USERNAME": "XXXX",
            "TWITTER_PASSWORD": "XXXXX",
            "TWITTER_EMAIL": "XXXXXXX"
        },
        "voice": {
            "model": "en_US-hfc_female-medium"
        }
    },

[odilitime]

I like a lot of the work here, I may merge it and then take out the config stuff. You do excellent typescript work

[BalanaguYashwanth]

Thanks a lot @odilitime for appreciation, So current action item is

• To remove config stuff from wherever new config changes are appended, and keep the typescript part.

Is that true ?

[odilitime]

Yes. Also I like IAgentConfig stuff so keep that

[BalanaguYashwanth]

@odilitime If i remove config part, then i need to remove the IAgentConfig part as well, Because there is no use of it.

So whats your opinion ?

[odilitime]

hrm I guess you're right, we don't need it currently and when I have a use I know where to copy the pattern from

[BalanaguYashwanth]

ok thanks, let me remove config and get the updated PR

[BalanaguYashwanth]

I added this piece of code, without this tweets won't generate into twitter
generateNewTweetLoop();

Note - Validate this piece of code, required or not

[odilitime]

I caught that and PR'd that earlier too

[BalanaguYashwanth]

Got it

[BalanaguYashwanth]

Updated the PR @odilitime,

Also I tried to pass the integration-test but getting issue of below error, even through i am using the node v23.3.0

WARN  Unsupported engine: wanted: {"node":"23.3.0"} (current: {"node":"v23.4.0","pnpm":"9.4.0"})

More details - https://github.com/ai16z/eliza/actions/runs/12322163072/job/34395124357?pr=1036

[odilitime]

Just has a conflict in pnpm-lock.yaml I can't resolve. See if you can fix that and we'll get this merged!

[BalanaguYashwanth]

@odilitime PR updated

[odilitime]

argh, more conflicts, sorry but I can't merge until those are resolved too

[BalanaguYashwanth]

Thanks a lot @odilitime