Correct pattern matching (#16)

* Correct pattern matching * Add missing gettext message
elixirschool · Jan 21, 2019 · 83dcbf1 · 83dcbf1
1 parent 5cbf0cb
commit 83dcbf1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/lib/admissions/registrar.ex b/lib/admissions/registrar.ex
@@ -20,7 +20,7 @@ defmodule Admissions.Registrar do
   end
 
   defp contributor?(client, nickname, org, repo) do
-    with {_status_code, contributors, _http_response} <- Contributors.list(client, org, repo)
+    with contributors when is_list(contributors) <- Contributors.list(client, org, repo)
     do
       Enum.any?(contributors, &(Map.get(&1, "login") == nickname))
     else

diff --git a/priv/gettext/default.pot b/priv/gettext/default.pot
@@ -50,10 +50,10 @@ msgstr ""
 
 #, elixir-format
 #: lib/admissions_web/templates/registrar/eligible.html.eex:2
-msgid "eligible_title"
+msgid "eligible_title %{nickname}"
 msgstr ""
 
 #, elixir-format
 #: lib/admissions_web/templates/registrar/ineligible.html.eex:2
-msgid "eligible_title %{nickname}"
+msgid "ineligible_title"
 msgstr ""
diff --git a/priv/gettext/en/LC_MESSAGES/default.po b/priv/gettext/en/LC_MESSAGES/default.po
@@ -58,3 +58,8 @@ msgstr "Thank you for your contributions, this wouldn’t be the same without yo
 #: lib/admissions_web/templates/registrar/ineligible.html.eex:2
 msgid "eligible_title %{nickname}"
 msgstr "🎉 You're eligible, %{nickname}!"
+
+#, elixir-format
+#: lib/admissions_web/templates/registrar/ineligible.html.eex:2
+msgid "ineligible_title"
+msgstr "Currently ineligible"