fix inspecting dynamc with interpolated named bindings

elixir-ecto · Nov 2, 2024 · d0f51ff · d0f51ff
1 parent a54d96f
commit d0f51ff
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/ecto/query/inspect.ex b/lib/ecto/query/inspect.ex
@@ -12,7 +12,11 @@ defimpl Inspect, for: Ecto.Query.DynamicExpr do
       |> Enum.map(&%JoinExpr{ix: &1})
 
     aliases =
-      for({as, _} when is_atom(as) <- binding, do: as)
+      Enum.flat_map(binding, fn
+        {as, _} when is_atom(as) -> [as]
+        {{:^, _, [as]}, _} when is_atom(as) -> [as]
+        _ -> []
+      end)
       |> Enum.with_index()
       |> Map.new()
 

diff --git a/test/ecto/query/inspect_test.exs b/test/ecto/query/inspect_test.exs
@@ -41,6 +41,9 @@ defmodule Ecto.Query.InspectTest do
     assert inspect(dynamic([comments: c], c.bar == ^1)) ==
              "dynamic([comments: c], c.bar == ^1)"
 
+    assert inspect(dynamic([{^:comments, c}], c.bar == ^1)) ==
+             "dynamic([{^:comments, c}], c.bar == ^1)"
+
     dynamic = dynamic([p], p.bar == ^1)
 
     assert inspect(dynamic([p], ^dynamic and p.foo == ^0)) ==