Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with dynamic properties #548

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Fix issues with dynamic properties #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47c6af0
make index a defined property, and type hint properties
scottaubrey Nov 8, 2024
4379ad6
make sample a defined property
scottaubrey Nov 8, 2024
4bcac50
remove $client, and define $mappedClient and $plainClient with correc…
scottaubrey Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Search/Api/Elasticsearch/PlainElasticsearchClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@

class PlainElasticsearchClient
{
private $libraryClient;
private Client $libraryClient;

private string $index;

public function __construct(Client $libraryClient, string $index)
{
Expand Down
2 changes: 2 additions & 0 deletions tests/src/Search/IndexMetadataTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

class IndexMetadataTest extends TestCase
{
private IndexMetadata $sample;

public function setUp(): void
{
$this->sample = IndexMetadata::fromContents('search_2', 'search_1');
Expand Down
8 changes: 4 additions & 4 deletions tests/src/Search/Web/ElasticTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
use eLife\Search\Kernel;
use eLife\Search\KeyValueStore\ElasticSearchKeyValueStore;
use Psr\Log\NullLogger;
use RuntimeException;
use Symfony\Component\BrowserKit\Client;
use Symfony\Component\Console\Application;
use Symfony\Component\Console\Input\StringInput;
use Symfony\Component\Console\Output\StreamOutput;
Expand All @@ -20,8 +18,10 @@
abstract class ElasticTestCase extends WebTestCase
{
protected $console;
/** @var MappedElasticsearchClient */
protected $client;

protected MappedElasticsearchClient $mappedClient;

protected PlainElasticsearchClient $plainClient;

public function getCollectionFixture(int $num)
{
Expand Down