Merge pull request #548 from elifesciences/fix-issues-with-dynamic-pr…

…operties Fix issues with dynamic properties
elifesciences · Nov 8, 2024 · 488c33f · 488c33f
2 parents bf024fd + 4bcac50
commit 488c33f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/src/Search/Api/Elasticsearch/PlainElasticsearchClient.php b/src/Search/Api/Elasticsearch/PlainElasticsearchClient.php
@@ -6,7 +6,9 @@
 
 class PlainElasticsearchClient
 {
-    private $libraryClient;
+    private Client $libraryClient;
+
+    private string $index;
 
     public function __construct(Client $libraryClient, string $index)
     {

diff --git a/tests/src/Search/IndexMetadataTest.php b/tests/src/Search/IndexMetadataTest.php
@@ -7,6 +7,8 @@
 
 class IndexMetadataTest extends TestCase
 {
+    private IndexMetadata $sample;
+
     public function setUp(): void
     {
         $this->sample = IndexMetadata::fromContents('search_2', 'search_1');

diff --git a/tests/src/Search/Web/ElasticTestCase.php b/tests/src/Search/Web/ElasticTestCase.php
@@ -9,8 +9,6 @@
 use eLife\Search\Kernel;
 use eLife\Search\KeyValueStore\ElasticSearchKeyValueStore;
 use Psr\Log\NullLogger;
-use RuntimeException;
-use Symfony\Component\BrowserKit\Client;
 use Symfony\Component\Console\Application;
 use Symfony\Component\Console\Input\StringInput;
 use Symfony\Component\Console\Output\StreamOutput;
@@ -20,8 +18,10 @@
 abstract class ElasticTestCase extends WebTestCase
 {
     protected $console;
-    /** @var MappedElasticsearchClient */
-    protected $client;
+
+    protected MappedElasticsearchClient $mappedClient;
+
+    protected PlainElasticsearchClient $plainClient;
 
     public function getCollectionFixture(int $num)
     {