GenDB, typos, and updated couchapp version #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves debugging.
Update couchapp version
Improves debugging.
…rts helpful error message if dbname is absent
Conflicts: tasks/couchapp.js
modified: tasks/couchapp.js
added 'db' to the var list in grunt.registerMultiTask("rmcouchdb",...)
and grunt.registerMultiTask("mkcouchdb",..).
Also, Emacs got rid of some white space. Sorry about that bit of
extraneous patching.
at the end of the two main functions, add "return null;" because otherwise Emacs javascript parser whinges about not returning something from a routine. I guess it is in the standard and all that. apologies if this is noise, but that's why I'm making tiny commits...you can ignore them.
return null;
genDB was repeated. deleted the second one
declare 'db' var in both functions
…rs are encountered.
Improved error checking and added support for new-style (directory-based) couchapps.
…-based app structure.
…butors in package.json.
Fixed bug when adding attachments to directory-based couchapp.
removes the horn sound on push, which breaks on linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest node.couchapp.js version has better error handling, among other improvements.
grunt demostill works just fine.This also merges @chewbranca's genDB helper, which cleans up the tasks code a bit. Also fixed a couple typos.