Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incsrch: add ^g/^#g as a duplicate of ^Enter/^#Enter #2335

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rampitec
Copy link
Contributor

@rampitec rampitec commented Aug 5, 2024

Some terminals (like the default terminal of Ubuntu 24.04) steal
^Enter from the apps. Adding duplicate hotkeys to work in --tty
mode.

Bumped version to 2.2.

Some terminals (like the default terminal of Ubuntu 24.04) steal
^Enter from the apps. Adding duplicate hotkeys to work in --tty
mode.

Bumped version to 2.2.
@rampitec
Copy link
Contributor Author

rampitec commented Aug 5, 2024

Includes changes from #2328 as there is no easy way to create stacked reviews on github.

@rampitec
Copy link
Contributor Author

rampitec commented Aug 5, 2024

@unxed The change we have discussed.

@@ -80,6 +80,7 @@ BOOL CollectEvents(void)
PutEvent(KC_BACK);
continue;
case VK_RETURN:
case 'G':
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said: this is the only functional change.

@elfmz
Copy link
Owner

elfmz commented Aug 12, 2024

again want to remind that there is 'sticky controls ' feature, in this case Pressing Ctrl+Space then Enter should work as Ctrl+Enter

@rampitec
Copy link
Contributor Author

again want to remind that there is 'sticky controls ' feature, in this case Pressing Ctrl+Space then Enter should work as Ctrl+Enter

Do you mean in the gnome-terminal? Anyway, pressing 2 combinations is less convenient.

@rampitec
Copy link
Contributor Author

I will also have to rebase this on #2338 or that on this, whetever and if merged first into master.

@rampitec
Copy link
Contributor Author

again want to remind that there is 'sticky controls ' feature, in this case Pressing Ctrl+Space then Enter should work as Ctrl+Enter

I have booted Ubuntu and tried sticky keys. It is actually not convenient, I really need to press it twice, and usually when searching it takes multiple 'find next' attempts, while ^space only lasts for one single keypress.

I also have to clarify, this is not a global hotkey. It is only when plugin reads input within its own OpenPlugin.

@rampitec
Copy link
Contributor Author

Ping

@rampitec
Copy link
Contributor Author

Ping. I am using it for a month or so w/o new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants