Add Update Progress Indicator #356
Open
+47
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
reviewed
Dec 16, 2024
|
|
stsdc
approved these changes
Dec 16, 2024
|
I just did my latest tests and it works as expected.
|
|
For me the whole updates box changes width when the values are being updated. It happens when numbers change. The effect is the jumping width. |
- Lessen scope - Lessen coupling - Rename the method to avoid confusion of the getter method - Unify naming notation: "xxx_size_str" is stringfied data of "xxx_size"
|
No, this PR was only for vertical changes. For horizontal I proposed here in comments. |
Do you have a screenshot or any way to reproduce the bug? |
|
I have posted screenshots in the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #310
Requires: elementary/settings-daemon#173