DefaultPlug: add settings for pdf viewer #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
reviewed
Nov 29, 2025
|
|
||
| var pdf_setting = new SettingsChild ( | ||
| _("PDF Viewer"), | ||
| "application/pdf" |
Member
There was a problem hiding this comment.
I wonder if we should change this to "Document Viewer" and also change some of these other document file types? https://gitlab.gnome.org/GNOME/papers/-/blob/main/meson.build?ref_type=heads#L220
Member
Author
There was a problem hiding this comment.
I'm not opposed to your suggestion, but other PDF viewers may not support most of those content types. Should we really want to do this? 🤔
The following warnings are shown when selecting Okular:
(io.elementary.settings:33919): io.elementary.settings.applications-CRITICAL **: 14:56:52.109: DefaultPlug.vala:154: Okular does not support content type application/vnd.comicbook-rar
(io.elementary.settings:33919): io.elementary.settings.applications-CRITICAL **: 14:56:52.115: DefaultPlug.vala:154: Okular does not support content type application/vnd.comicbook+zip
(io.elementary.settings:33919): io.elementary.settings.applications-CRITICAL **: 14:56:52.119: DefaultPlug.vala:154: Okular does not support content type application/x-cb7
(io.elementary.settings:33919): io.elementary.settings.applications-CRITICAL **: 14:56:52.143: DefaultPlug.vala:154: Okular does not support content type application/x-ext-cb7
(io.elementary.settings:33919): io.elementary.settings.applications-CRITICAL **: 14:56:52.146: DefaultPlug.vala:154: Okular does not support content type application/x-ext-cbr
(io.elementary.settings:33919): io.elementary.settings.applications-CRITICAL **: 14:56:52.148: DefaultPlug.vala:154: Okular does not support content type application/x-ext-cbt
(io.elementary.settings:33919): io.elementary.settings.applications-CRITICAL **: 14:56:52.153: DefaultPlug.vala:154: Okular does not support content type application/x-ext-cbz
(io.elementary.settings:33919): io.elementary.settings.applications-CRITICAL **: 14:56:52.158: DefaultPlug.vala:154: Okular does not support content type application/x-ext-djv
(io.elementary.settings:33919): io.elementary.settings.applications-CRITICAL **: 14:56:52.163: DefaultPlug.vala:154: Okular does not support content type application/x-ext-djvu
(io.elementary.settings:33919): io.elementary.settings.applications-CRITICAL **: 14:56:52.172: DefaultPlug.vala:154: Okular does not support content type image/vnd.djvu+multipage
(io.elementary.settings:33919): io.elementary.settings.applications-CRITICAL **: 14:56:52.175: DefaultPlug.vala:154: Okular does not support content type application/illustrator
(io.elementary.settings:33919): io.elementary.settings.applications-CRITICAL **: 14:56:52.191: DefaultPlug.vala:154: Okular does not support content type application/x-ext-pdf
(io.elementary.settings:33919): io.elementary.settings.applications-CRITICAL **: 14:56:52.200: DefaultPlug.vala:154: Okular does not support content type application/x-xzpdf
Member
Author
There was a problem hiding this comment.
I pushed the changes to https://github.com/elementary/settings-applications/tree/research/ryonakano/default-pdf for test
danirabbit
approved these changes
Dec 5, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Let's go with this as-is and we can always re-evaluate adding more types later if necessary :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #266
I also refactored
get_types_for_app ()while I'm here.Checklist
I installed Okular from Flathub and confirmed that: