Conversation
There was a problem hiding this comment.
Everything works as before afaict. There is a small oddity in that the guest avatar color changes depending on whether they are logged in or not whereas normal users (with no loadable icon) the color is fixed and apparently random (not their accent color). Not sure if this is intended.
There is some repeated code for removing color classes.
Conflict resolution required.
@jeremypw can you elaborate on where you're seeing that? In the list of logged in users, in the header, when logged in as another user, on the main settings page, etc? I'm not seeing a difference here.
Adw.Avatar bases its color on a hash of the name supplied to it. I agree it should use their accent color, but I think that's outside the scope of this branch
I'm not sure it's worth trying to do anything about that at the moment. In GTK4 it'll be a single line |
|
Sorry this fell off the radar. Looking at it again I cannot reproduce that color issue I reported before. I also noticed that it fixed an issue I noticed in the master branch. I'll approve this now. |
Fixes #125
Have
UserRowhandle the case where its user is the current user instead of duplicating all that code into another widget